TradeMe with API to create custom trades (1.7.10-1.21.x)

Some improvements relating to trading action logging. This will need latest CMILib version to take full effect.
Increased log list amount from 3 to 10 in /trade log command
Added option to disable accept/decline buttons when someone offers you trade
Fix for glitched out trade mode buttons if you clicked Q while hovering over mode or amount sections. It was just a visual glitch.
Fix for mcmmo exp trading

----------, Aug 4, 2023

Optimize

Optimized performance when it comes to recording trade into database

----------, Jul 20, 2023

Folia

Reworked permission handling to be more in line with other plugins
New command /trade checkperm [keyword] which will output all permission nodes currently in use if no keyword was used or only those relating to entered word
trademe.logitemsothers changed to trademe.command.logitems.others
trademe.log.others changed to trademe.command.log.others
Fix for issue when you are consuming item while opening trade with someone
Added Folia server support. Update CMILib to the latest version. If any errors happen while running this plugin on Folia server, let me know. Some kinks might still need to be refined.

----------, Jul 14, 2023

Fix for issue relating to players without permission to trade items still being able to do so

----------, May 10, 2023

Fixing issue introduced in latest patch which could have removed items placed in trade window if you closed trade without accepting it.

----------, Jan 20, 2023

Bug fix

Tackling issue with bugged out GUI in some situations

----------, Jan 20, 2023

Fixing issue where trade confirm button would not have worked in some servers

----------, Jan 10, 2023

Logs

Added extra fail safe check when confirming trades
Added option (enabled by default) to record players clicks and actions during trades even if trade is canceled. This will help out to figure out possible exploits in the future. Files will be saved into tradeActions folder, which is separate from dupeLogs
Added option to auto delete log files for tradeActions and dupeLogs. By default we will keep dupe logs for 30 days and trade action logs for 3 days, you can always adjust those values to your liking. Keep in mind that logs will only be removed on server startup.

----------, Jan 9, 2023

Fixing

Don't forget to update CMILib as newest version will be required for this update to work properly.

Small fix while recording trade information into database
Small change for dupeLogs relating to click event being canceled or not.
Added options to disable exploit detector. We will have this option disabled by default, so enable it if you want to perform this check on trading.
Added option to disable item reset if potential item exploit was detected. When enabled we will reset players items to original state as it was at start of trade, which means that if player gained items with exploiting or not while trade window was opened would be lost. You can disable this to prevent potential legit item loss while allowing potential item dupe to go through while still having record in console about potential exploit with items list.
Fix for issue where items could be removed from offer while confirmation of trade was already running
Added better detection by player nick name, this will require you to update CMILib plugin
Fix for possible item loss in case you die while having items placed in trade menu
Fix for filler itemstacks having their original name and not empty field as it should

----------, Jul 4, 2022

Fixing issue relating to having active trade while server/plugin shut downs, which could have resulted into some issues.

----------, Jan 31, 2022

Order

Added option to define order you want to show custom trading in. This will allow you to have same order each time you trade and put more important trade modes at front.

----------, Nov 15, 2021

Fixing

Fix for error message when using MySQL database informing about outdated class usage
Fixing issue with exp trade showing some what inconsistent and confusing resulting values when both players try to trade exp to each other

----------, Oct 27, 2021

1.17 and full transition into CMILib system

Fix for issue when plugin would fail to initiate trade if one of the supported plugins failed to process data properly
Fix for Jobs maxvip level permission node being ignored while trying to trade jobs exp points
Fix for some rare situations when trading Jobs points would not have saved change into database

----------, Aug 30, 2021

Small

Quick fix for issue with older servers and incorrect sound values causing plugin to fail initial loading.

----------, Aug 16, 2021

Placeholders and NBT

Fixing issue with blacklisted lore not being taken into consideration and player was able to trade blacklisted items. This will require CMILib to be updated to take full effect.
Fix for quickbar lock not working as it should. This is relating to previous issue fix as its originating from same bug
Fix for accepted trade buttons showing wrong messages
Added initial placeholderAPI support.
New placeholder as %trademe_user_hasTradeToggledOn% which will return true or false depending if player accepts trades or not. If you have list of placeholders you would want to see please make a ticket with full list and basic explanation what each of them should return.
Added option to block item trade by its NBT path. This only checks if NBT path exists and not what contents of it we have. You can use this to block special items with special custom NBT entries, avoid using generic ones like 'display.Name' which would block trading items with custom name, unless you actually need this
Extra message for item being blocked from trade will be shown in UI title section, just to be more noticable why you can click on specific item to trade it. We still have action bar message, but that one can be hard to see in some situations
Removed few lines from locale file to redirect and use them from CMILib which is more centralized place for it.
Fixing support for new WorldGuard API causing errors

----------, Aug 2, 2021

1.17 server support update. Last plugin which goes into CMILib type environment. As of 6.1.0.0 plugin will need CMILib to function properly. Plugin size went down due to this change from 583Kb to 296Kb.

----------, Jun 23, 2021

MyPet and fixes

Improved command handling for more robust and faster approach
Fix for token trading creating error
Fix for new MyPet 3.x API causing issues
Fix for feedback message showing incorrect item values in some situations. It dint effected actually amount player got, it was just a visual bug

----------, Mar 17, 2021

Magic

Fix for issue with plugins like Magic which tends to modify inventory just before opening trade window which wants to trigger item dupe protection as initial and end inventories doesn't match.

----------, Nov 30, 2020

1.16.4

Updated for 1.16.4 servers

----------, Nov 3, 2020

MMOCore

Fix for incorrect plugin version always informing about new one even if you already have newest
Fix for sometimes plugin failing to load in case you have issue while loading plugin incompatibilities with other plugins
Now trade modes should keep their order in gui
Fix for money trading showing big numbers with E instead of showing full one or shortened if enabled in config file
Added support for mmocore skill point trading
Added support for mmocore attribute point trading

Keep in mind that MMOCore currently is in early support mode and might need some extra adjustment and balance. If you have any ideas feel free to give suggestions at github

----------, Sep 7, 2020

1.16.2

Updated for 1.16 server
Updated base libraries
Added support for hex colors by name and by general one. This adds gradient support too.

----------, Aug 19, 2020

Fixing issue when one of the trading players has no access to item trade which would block trade
Updated json type message handling when it comes to hex colors

----------, Jul 6, 2020

1.16

Updated to properly support 1.16 servers
Now locale supports hex codes like {#6600cc}. Only applies for 1.16+ servers

----------, Jun 29, 2020

Och

just quick one, forgot to remove some debug code.

----------, Apr 29, 2020

Bug

Fixing bugs related to spigot platform. This will not have effect if you have had paperSpigot or anything what is based on its platform.
Added extra fail-safe checks when trade fails and one of the trading players remains in trade window.
Couple extra small changes code wise.

----------, Apr 29, 2020

Quick

Fix for issue with older servers not processing trade properly

----------, Apr 15, 2020

TokenManager

Fix for issue when trying to load plugin on older than 1.13 versions
Added support for TokenManager plugin

----------, Apr 15, 2020

DnD

Fix for trade log wanting to clear out logs which should not be cleared
Added sqlite database vacuum mode, which will minimize your database file
Added some extra layer of protection

----------, Apr 10, 2020

Locale

Fix for GUI title not adding color codes when generating it with player names who want to trade. Keep in mind that we can only put 32 characters in title and color codes takes atleast 2 slots from that.
Added extra locale line for jobs offer list so you can customize it to your own liking.

----------, Feb 10, 2020

Res and stuff

Added option to translate received item list which includes an option to define colors
Fixed issue with item list you received from trade adding separator at the end
Fix for issue with residence trading which would allow to have more residences over allowed residence limits
Update some of the code to be more version independent. Which will mean that in future it should continue working with new versions of minecraft without any additional special update.

----------, Feb 4, 2020

1.15

Support for 1.15 servers
Fix for log not showing a record of a player if the name provided was in different capitalization
Fix for issue when you would click on log entry of someones trade log and it would show your own
Now some of the items in Gui will not have useless information, like damage when you hold it in your main hand. This only applies for the buttons and not for the tradable items, so you can still see exactly what item you are getting.
Fix for issue with Jobs exp trading not removing properly traded exp from source player
Now you can trade Jobs exp in fractions, so if you have 19.25exp, you can trade all of this and after the trade it will not be averaged to hole numbers as before.

----------, Dec 12, 2019

Locale fix

Fix for issue with locale file not generating properly trade mode locale lines

----------, Oct 6, 2019

Jobs new API

Updated to support changed Jobs Reborn API when dealing with its points trading

----------, Sep 5, 2019

Version...

Quick one, forgot to increase version in plugin file...

----------, Aug 12, 2019

Fix for gamemodes locale resetting to default one after each plugin reload instead of keeping changes you have made

----------, Aug 12, 2019

Fix related initial plugin startup when you don't have TradeMe folder present

----------, Jun 13, 2019

Locale things

Some fixes to miss formatted french locale file.
Updated locale file handling in general and now if we will fail to load locale, in example when you have miss formatted file, then backup copy of that file will be created for you to check it out and maybe fix issues. As miss formatted file gets reseted to default one (English) by default, just to keep plugin running even tho language will be "wrong" one.

----------, Jun 10, 2019

Quick one

Small fix related to deprecated getid() method in 1.14+ servers
Now filler buttons should not display item name but instead and empty field as of request

----------, May 19, 2019

1.14

Initial release to support 1.14+ servers

----------, May 19, 2019

Fix?

Attempt to fix issue when items could disappear if you would cancel trade while counter is running. Could not reproduce this issue on test server, so some feedback would be nice (Discord pm's work too )

----------, Apr 23, 2019

Sounds

Fix for issue when trying to trade with some one who has full inventory and confirmation of trade still proceeds when it should not allow this
Fix for sounds not accepting new pitch
New sounds for amount changes

----------, Mar 1, 2019

Sounds

Fix for issue when trying to trade with some one who has full inventory and confirmation of trade still proceeds when it should not allow this
Fix for sounds not accepting new pitch
New sounds for amount changes

----------, Mar 1, 2019

Fix for issue when loading plugin on older mc versions like 1.8
Fix for issue with trade cancellation while counter is running
Fix for issue when cleaning up accept trade list when player logs out

----------, Dec 3, 2018

Small fix related to older versions and item detection

----------, Oct 24, 2018

MyPet

Small fix for changed MyPet API throwing error message

----------, Oct 23, 2018

New and better

Completely removed old GUI handling as it was... Outdated. Remade it to run on CMI gui engine which is allot more flexible and more reliable when it comes to items being bugged out of inventory or clicking on inventory in general.
General library updates for better plugin handling.
API got some minor changes so plugins using old API will have to update it. Its quite minor changes, but they had to be done, check gitHub example plugin which contains full code examples.
Some trade values changed from decimal ones to full numbers. So no more information values like 5.0 when you cant have decimal value for that type of trading.
Now trade window title will update with some nice information when another player changes trading values. This is allot more convenient then action bar messages which can be hard to see.
Fixed issue with Sounds not being recognized in 1.13+ servers as of new changed names
Config file update to handle materials by names or by id and some general simplifications. So please update your config file if you had some custom values.
Added option to define sounds used while clicking on trade window. Check config file for those ones.
Fixed issue with new WorldGuard API changes introduced with 7.x version.

This is Experimental version, did tested out everything what i could think of to check out if its working properly with new GUI engine, but one head is always not as good as couple of them

----------, Oct 22, 2018

Fix for issue related to player display name

P.S. Working on some major rework to update entire code as its quite outdated.

----------, Oct 18, 2018

Fix for issue with tellraw messages when making offer

----------, Oct 16, 2018

1.13.1

Updated to properly handle new API for 1.13.1 servers.
General library update.

----------, Sep 3, 2018

1.13

Initial update to support 1.13 servers.
Now GUI title will show players display name if possible and will shorten it to 16 characters in case its longer than this.

----------, Aug 3, 2018

Fix for issue with balance check

----------, Jul 21, 2018

Small things

Small fix for error message showing trade. instead of treademe. permission node
Extra check to be sure that trade window opened for both players successfully. This to address plugins which could prevent inventory from opening if player is in combat or some special conditions.

----------, Jul 5, 2018

Wrong one

Sorry about this, previous update was wrong export...

----------, May 4, 2018

Kingdoms

Some improvements for invalid Kingdoms plugin detection
Extra protection to prevent trading with dead people. Yea, this is a possible thing when client bugs out.
Small fix for colorization for console messages.

----------, May 4, 2018

Kingdoms

Error catcher when kingdoms support fails to initialize. Will need to investigate further why this happening with nevest version. For now, it will disable Kingdoms trading if it fails, but will allow other trade types.

----------, May 3, 2018

Some fix

Thanks to UnioDex pointing out and coming up with solution. So all credits for this fix goes to him.

Added extra protection to prevent players, who are in trade mode, from sending chat messages or performing commands. This should minimize possibilities for hacked clients to send actions they should not have access too while trading.

----------, Mar 17, 2018

Filling

Now right side should be fully filled with gray glass panels, just to minimize possibility for reported (not reproduced) issue when player would click on wrong side and loose items.
Some small tweaks.

----------, Mar 15, 2018

Small fix for version checker throwing error message about failed check.

----------, Feb 20, 2018

Small change

Added extra objects for TradeFinishEvent to include actual TradeInfo objects into it, so you can adjust trades if needed by your needs.

----------, Feb 15, 2018

Small fixes and changes

Help page change, removed page count line, changed pagination to include page numbers
Small adjustment on GUI update interval to minimize possibility for items to glitch out
Full customization of help page and explanation page
Small fix for mypet trade

----------, Feb 14, 2018

Log

Small fix for issue with PlayerPoints handler
Remade log handler so now its allot faster even when we have huge amount of logs saved
Added missing locale lines for residence trade.

----------, Oct 13, 2017

GriefPrevention

Added option to define minimum amount of blocks player should keep after trade

----------, Oct 8, 2017

Residence

Added option to prevent trading in specific residences
Fixed issue when error message occurs when checking for WorldGuard region but it's not installed on server
Small typo fix for default locale files

----------, Oct 3, 2017

Some fix for 1.7.10 servers (we have 1.12.2 out...) and exp trade issue
Small remake for message on trade offer, now it will show 2 lines and can be shrinked to one if needed by removing \n in locale file for appropriate line

----------, Sep 21, 2017

Fix for tab not working
Couple fixes for incorrect command descriptions. Will not have any effect if you have used older versions. It just default ones got messed up a little bit.

----------, Aug 16, 2017

Basic recode

This is official PreRelease version as plugin size grown up by additional 50% just because of new libraries and new features. So please test out know issues to be certain that it's now working properly.

Changed how locale/config files are being handled, to be in same area as other mine plugins.
Ther e was some rearrangement of some locale lines and some will get defaulted to English. Please double check your locale file after update.
Now trading will be stopped if one of the players gets damage.
"Rolled back" money trading finalizing method, hopefully to help out with situations when it's not giving money to a receiver but takes them from the giver.
Fix /trade log not showing traded items

Couple other small fixes

"New" command /trade offer (playerName) which simple give trade request. This is same as simply typing in /trade (playerName)

Added new command /trade logitems (playerName) [id] which will show full list of traded items including their displayname, lore, enchants and so on. This will only work with new trades. old trades will only show item type. For simpler use /trade log (playerName) command will show list of logs and by pressing on one of them which contains item trade will show detailed information about traded items.

----------, Aug 6, 2017

Removed that silly message appearing when you are not trading with money.
Some different method on saving config and locale file to try avoiding messed up files when they need UTF-8 encoding
Trade mode icons now should keep their order and not be "randomized"

----------, Jun 26, 2017

Changed money handling on trade finish to have more checks if money deduction was correct from source player before giving them to another player.
Better increment showing to show full numbers instead of automatic shortened, in example: 10E17
Added default locale file for Chinese language thanks to Pangxie

----------, Jun 5, 2017

1.12

Initial update for 1.12 servers
Small fix for handling huge amounts of exp trades
Fix for TradeFinishEvent on its cancel items not being returned to players
Fix for API duplicating trade modes when reloading TradeMe Addon.

----------, May 17, 2017

Small change

As there is some issues with decimal money amounts with some plugins, when you are setting more than you have, value will be set to full number, in example if you have 10023.45 you will trade 10023, just to avoid possible issues with that decimal value.

----------, May 14, 2017

Additional fail safe in case money withdrawal from player fails to stop money transfer.
Bigger numbers, which would be shown as 1.0E13 now should be shown in normal format. Keep in mind that you can use ShortNames feature to shorten big numbers if you don't care about precision.
Tax line will be moved to another line now, just to avoid to long ones.

Updated API example plugin (GitHub) with additional Money class example

----------, May 14, 2017

Fail safe for non existing item stack for trade buttons. This is mainly for older server versions not having new types of blocks.

----------, Feb 19, 2017

HUGE numbers

Some "fix" to handle money transactions over 2.147.483.647 up to 10.000.000.000.000 (this only applies when using essentials economy system, other systems don't have hard limit as essentials limits it self up to this number). If offered money amount exceeds this amount (yes, there is servers who have so many money ), player will get message informing about that and will prevent rising money over this hard limit.
API For thos who using it, there is some change for increment handling and old get method is marked as deprecated as now new getAmount will return double value instead of int to handle bigger amounts set in config file.

----------, Feb 12, 2017

Small fix for missing locale when trade is finished and item list is being shown

----------, Jan 28, 2017

Small fix

Small fix addressing issue when launching plugin for the first time with new 5.0 version.

----------, Jan 26, 2017

API

Some fix for MyPet trading
Some small fix for GriefPrevention
Re-coded big chunk of code on how trading modes are handled and now TradeMe will support option to add custom trade modes with some simple plugins. Example plugin is in 9kb size and you can find it over github. Its as simple as it can get, you will need only 2 classes for it to implement new trade mode. Some extra explanations will be coming later on, mainly just to show how to add trades with accept fields, but you can always check it in main plugin as its working in same way and trade mode are being added in same way as you would be adding new trade modes with 3rd party plugin. Enjoy

----------, Jan 26, 2017

For for exp not wanting to recognize your current exp amount
"fix" for TradeFinishEvent event if canceled not canceling trade.

----------, Jan 24, 2017

Small fix addressing issue for TradeFinishevent not returning traded items.

----------, Jan 8, 2017

Events

Fix for locale file not wanting to be generated on plugin first run
Added extra feedback information on TradeFinishEvent to have option extracting all traded objects
Some code cleaning so plugin size dropped

----------, Jan 3, 2017

Some optimization when saving trade information into data base
Added option to disable trade saving if you are not using it.
Some change for griefprevention handling to be more forgiving when checking for default block amount.
Some change on locale handling, now using same method as Residence plugin as there was no reports for issues with utf-8 encoding, hopping this will help out for thos ho cant use currently trademe locale in their language.

----------, Dec 27, 2016

McMMO

Added support for McMMO Exponential exp gain.
You don't need to provide base and multiplaier any more, values will be taken directly from McMMO folder
Keep in mind that Cumulative_Curve is not supported as it makes everything overcomplicated and i will need to do some extra experimenting to get correct results when using that McMMO feature
Recompiled against 1.11 version just to be safe with new API

----------, Nov 22, 2016

Fix for last fix... Thats what happens when you are rushing...

----------, Oct 4, 2016

Small fix related jobs points when they are in negative value and preventing for trade to be finished.
BungeeCord trading is disabled for time being to sort out some issues related to it.

----------, Oct 4, 2016

Events

Added 3 events to be fired when certain action are being done. Currently its just basic stuff to have starting point, if you have some additional requests or need additional events on another actions, just give me a shout.
- TradeEndEvent - fired when trade is ended by one of players
- TradeFinishEvent - fired when trade is successfully finished
- TradeStartEvent - fired when trade is being started

----------, Aug 26, 2016

Fix for new updated residence API, please use latest version of residence if you are updating to this version and want to have residence trade support.

----------, Aug 11, 2016

Fix for locale file not wanting to be created on first plugin run
Some fixes related to Mypet trade as of Keyle report
Some fix for MyPet to show correct pet name you got after trade.

----------, Aug 11, 2016