Im so glad to see a dev read a review, accept the advice, not argue, and actually make the changes. So thank you Wynoria for that.
This update massively cleans up this script.
So much easier to read, gone are the days of those super long local variables, and staircases of if/else statements.
Thanks for the feedback on this new update.
The advice you have given me is extremely useful and I thank you for it.
Have a nice day!
Version: 1.0.0-SNAPSHOT-2
This resource is decent, but it has a lot of programming mistakes:
1) The odd use of over naming local variables:
Exhibit A:
""
set {_result::message_private::message_command::sending::all::01} to {@PREFIX_MESSAGE_SENDING}
set {_result::message_private::message_command::sending::player::02}
set {_result::message_private::message_command::sending::player::final}
set {_result::message_private::message_command::sending::sender::02}
set {_result::message_private::message_command::sending::sender::final}
""
This is so insanely unnecessary, and extremely hard to read.
Most of these are set to a value and only used once, therefor the variable is redundant, but the naming... the naming is just awful.
2) The staircase of death with poorly handled if/else statements.
Exhibit A:
""
if sender is a player:
if player doesn't have permission "wynomessageprivate.command.message" or "wynomessageprivate.command.*" or "wynomessageprivate.*":
<snipped>
if arg 1 isn't set:
<snipped>
else:
if arg 1 is offline:
<snipped>
else:
if arg 1 doesn't have permission "wynomessageprivate.notification.message" or "wynomessageprivate.notification.*" or "wynomessageprivate.*":
<snipped>
else:
if sender is arg 1:
<snipped>
else:
if arg 2 isn't set:
<snipped>
else:
""
I snipped out parts cause its mostly just messages.
Skript has "else if" for a reason.
This is basic Skript knowledge, and the staircases here just show lack of basic Skript knowledge.
3) Language:
The way the languages are handled in this code is overbearing to say the least. In a case of handling languages, you should just use options.
SUMMARY:
- Its alright, but message commands have been overdone to death
- really poor coding practices.