This skript works very great on 1.16.5 and works as almost intended. There are a few issues that I will list below.
1: You can spam /create while a server is being created. (pretty easy to fix tho)
2: The messages don't have a great configuration and they take a ton of effort to configure. Maybe put them into the options?
3: Sometimes upon restarting the server, all server data of /join and who's server it is is lost.
This is a great skript, even with all the bugs. It's pretty easy to patch all the vulnerabilities (major)within the skript, but it would be nice to get an update for people who do not have a good understanding of skript.
The script looks to be working decently, it does have a couple of concerns:
* 1: The name is incorrect, its more player worlds, it doesn't create a server.
* 2: Maybe prefix the worlds generated by this script.
* 3: If multiple worlds are deleted within 5 ticks, it could delete the data, but not the world. You might want to look into a queue system to fix this.
* 4: Maybe format the code so its more readable.
* 5: This script overrides important commands (ban, unban, kick, op, deop, stop, gamemode, whitelist)
[ERROR] Cannot recognise the type 'text' (test.sk, line 78: function psCreateServer(N: text, P: player):')
12:03:43[ERROR] Cannot recognise the type 'player' (test.sk, line 100: function psDelete(P: player):')
12:03:43[ERROR] Cannot recognise the type 'text' (test.sk, line 117: function psJoin(N: text, P: player):')
12:03:43[ERROR] Cannot recognise the type 'text' (test.sk, line 138: function psLoad(N: text):')
12:03:43[ERROR] Cannot recognise the type 'text' (test.sk, line 146: function psUnload(N: text):')
12:03:43[ERROR] Cannot recognise the type 'player' (test.sk, line 152: function psOnline(P: player):')
12:03:43[ERROR] Cannot recognise the type 'player' (test.sk, line 165: function psUpdateTab(P: player):')
12:03:43[ERROR] Cannot recognise the type 'player' (test.sk, line 168: function psPanel(P: player):')
12:03:43[ERROR] Cannot recognise the type 'player' (test.sk, line 178: function psAddons(P: player):')
12:03:43[ERROR] Cannot recognise the type 'player' (test.sk, line 192: function psPlayers(P: player):')
12:03:43[ERROR] #!#!
Hey there, there must be an issue whenever you copied/uploaded the code. The code 100% works, so this is the only possible reason. I would be more than happy to assist you in fixing this if you joined the PlayerServers discord server (in the resource description).
Version: dev1.0
GREAT! it's free, it works, and is so reliable. However, it would help if you could make a way to restrict the number of servers a player can create and restrict the amount of RAM the playerservers can use, that would be perfect.
The player should only be able to create one server, but im going to look into this incase it isn't working correctly. Furthmore, I will look into optimising it and minimising ram usage. Thank you for the positive review!