Ok.... this one again!

Lets start with the response to my previous review:
""
Thank you for your review. Starting from the fact that Skript in general for some functions may be not optimized and this does not depend on my code. As for the fact of the Nether / End is made on purpose that it takes only the world in which you are when you do /rtp.
""
1) Let's not blame Skript for your bad code.
I've personally written an RTP script and it functions very well, no lag, runs perfectly... if you know what you're doing.
Your excuses here aren't making you look like a better dev, they're only making you look worse as you have no clue what you're talking about.
2) seems weird you'd purposely not allow TP in other worlds, but you do you.


OK, now onto reviewing the recent update.
1) The code somehow got worse. Skript has a teleport effect, and if running on Paper, it async teleports, making for a smooth transition.
But nope, you're using console commands?!?! and what does using console commands mean? Well, 2 things:
a) Poor coding skills. Real devs use code, not console commands.
b) a flooded console and logs, exhibit A:
""
[14:29:43 INFO]: ShaneBee issued server command: /rtp
[14:29:43 INFO]: Applied effect Blindness to [♛OWNER♚] ShaneBee
[14:29:43 INFO]: Applied effect Slowness to [♛OWNER♚] ShaneBee
[14:29:43 INFO]: Teleported [♛OWNER♚] ShaneBee to 439.500000, 100.000000, 196.500000
[14:29:43 WARN]: ShaneBee moved too quickly! 1330.0,24.625,904.0
[14:29:43 WARN]: ShaneBee moved too quickly! 1330.0,24.625,904.0
[14:29:43 WARN]: ShaneBee moved too quickly! 1330.0,24.625,904.0
[14:29:43 WARN]: ShaneBee moved too quickly! 1330.0,24.625,904.0
[14:30:05 INFO]: ShaneBee issued server command: /rtp
[14:30:05 INFO]: Applied effect Blindness to [♛OWNER♚] ShaneBee
[14:30:05 INFO]: Applied effect Slowness to [♛OWNER♚] ShaneBee
[14:30:05 INFO]: Teleported [♛OWNER♚] ShaneBee to -111.500000, 100.000000, -780.500000
[14:30:05 WARN]: ShaneBee moved too quickly! -551.0,57.77837524746967,-977.0
[14:30:05 WARN]: ShaneBee moved too quickly! -551.0,57.77837524746967,-977.0
[14:30:05 WARN]: ShaneBee moved too quickly! -551.0,57.77837524746967,-977.0
[14:30:11 INFO]: ShaneBee issued server command: /rtp
[14:30:11 INFO]: Applied effect Blindness to [♛OWNER♚] ShaneBee
[14:30:11 INFO]: Applied effect Slowness to [♛OWNER♚] ShaneBee
[14:30:11 INFO]: Teleported [♛OWNER♚] ShaneBee to -18.500000, 100.000000, -0.500000
[14:30:11 WARN]: ShaneBee moved too quickly! 93.0,49.803374726683046,780.0
[14:30:11 WARN]: ShaneBee moved too quickly! 93.0,49.803374726683046,780.0
[14:30:16 INFO]: ShaneBee issued server command: /rtp
[14:30:16 INFO]: Applied effect Blindness to [♛OWNER♚] ShaneBee
[14:30:16 INFO]: Applied effect Slowness to [♛OWNER♚] ShaneBee
[14:30:16 INFO]: Teleported [♛OWNER♚] ShaneBee to 430.500000, 100.000000, 400.500000
[14:30:16 WARN]: ShaneBee moved too quickly! 449.0,49.37837272883691,401.0
[14:30:16 WARN]: ShaneBee moved too quickly! 449.0,49.37837272883691,401.0
[14:30:16 WARN]: ShaneBee moved too quickly! 449.0,49.37837272883691,401.0
[14:30:16 WARN]: ShaneBee moved too quickly! 449.0,49.37837272883691,401.0
[14:30:21 INFO]: ShaneBee issued server command: /rtp
[14:30:21 INFO]: Applied effect Blindness to [♛OWNER♚] ShaneBee
[14:30:21 INFO]: Applied effect Slowness to [♛OWNER♚] ShaneBee
[14:30:21 INFO]: Teleported [♛OWNER♚] ShaneBee to 980.500000, 100.000000, 55.500000
[14:30:21 WARN]: ShaneBee moved too quickly! 550.0,49.05333802104894,-345.0
[14:30:21 WARN]: ShaneBee moved too quickly! 550.0,49.05333802104894,-345.0
[14:30:27 INFO]: ShaneBee issued server command: /rtp
[14:30:27 INFO]: Applied effect Blindness to [♛OWNER♚] ShaneBee
[14:30:27 INFO]: Applied effect Slowness to [♛OWNER♚] ShaneBee
[14:30:27 INFO]: Teleported [♛OWNER♚] ShaneBee to 829.500000, 100.000000, -697.500000
[14:30:27 WARN]: ShaneBee moved too quickly! -151.0,49.953374769152134,-753.0
[14:30:27 WARN]: ShaneBee moved too quickly! -151.0,49.953374769152134,-753.0
""
As an operator, my screen in game is also flooded with these stupid messages.

2) using console commands for potion effects? Are you joking?
see #1

3) no safety checks. I added in some code to check how frequently I was teleported into an ocean:
"Ocean: 105/143 // 73.43%"
73% of my 143 runs of the "/rtp" command, landed me in the middle of the ocean.
On top of that, a couple times I was teleported into the middle of a mountain, I suffocated and died. This is due to teleporting the player to a y of 100 each time.
Incase you didn't know, the caves and cliffs update has higher mountains, they generated above 100.

4) Worlds:
Well... if Im in the end or nether, or any other world for that matter, I still get randomly teleported back to the main world. What if I don't want my players in the main world? What if my main world is a lobby type thing only?

5) The damage handler, I mean it works, its ok, but its just poor practice. Skript has a highest block at expression for a reason.

tl;dr:
This script is flooded full of bad coding practices and results in an extremely poor RTP experience, and a massive headache for a server owner.

Your reply is stupid

TL;DR - you replied to ShaneBee's review
Thank you for your review. Starting from the fact that Skript in general for some functions may be not optimized and this does not depend on my code. As for the fact of the Nether / End is made on purpose that it takes only the world in which you are when you do /rtp.

"As for the fact of the Nether / End is made on purpose that it takes only the world in which you are when you do /rtp." This is stupid. First, connecting a player to a world (serverside) takes less than a second, delaying a whole second if you rtp to the nether or end shouldn't happen.

"Starting from the fact that Skript in general for some functions may be not optimized and this does not depend on my code."
If the system can't handle your code, don't make it.. Also this is also completely IDIOTIC, I have made multiple rtp systems, where the systems involve over 10 worlds AND rapid world transfer, and it NEVER takes more than a second to teleport a player, and the way mine works is that it first teleports them to a limbo world, loads the desired world from memory if it is unloaded, and then teleports them to the world, and rtps them.
(This is way more than your system does, and it runs way better)
^^ Basically, a way more intense system works smoother than this shitstain you've made, and your reasons are stupid.

A RTP system that will pause for a second while it attempts to find a location is perfectly normal, but if it pauses the whole server, you screwed up.


"The first RandomTP Skript on the market that is optimized and updated" First of all, your system is NOT optimized, so don't lie, also this is NOT the first RTP skript on the market, and out of all of them this may be the worst running one.

[A RTP skript halting the main thread is one of the dumbest things ever, if enough people /rtp the server can freeze for over a minute, then could false anticheat ban players due to how anticheats don't like servers being frozen. ]

"The first RandomTP Skript on the market that is optimized and updated"
There is absolutely nothing optimized about this.

In fact, it's quite the opposite. Due to how this code is written, it halts the main thread, at least a second each time this command is run.

I added a simple time check into it, and here was the outcome:
""
[16:07:32 INFO]: ShaneBee issued server command: /rtp
[16:07:33 INFO]: Delay: 1.49 seconds
[16:07:53 INFO]: ShaneBee issued server command: /rtp
[16:07:54 INFO]: Delay: 1.25 seconds
[16:08:08 INFO]: ShaneBee issued server command: /rtp
[16:08:10 INFO]: Delay: 1.35 seconds
[16:08:21 INFO]: ShaneBee issued server command: /rtp
[16:08:22 INFO]: Delay: 1.3 seconds
[16:08:30 INFO]: ShaneBee issued server command: /rtp
[16:08:31 INFO]: Delay: 0.84 seconds
[16:08:35 INFO]: ShaneBee issued server command: /rtp
[16:08:36 INFO]: Delay: 1.12 seconds
[16:08:39 INFO]: ShaneBee issued server command: /rtp
[16:08:40 INFO]: Delay: 1.36 seconds
[16:08:48 INFO]: ShaneBee issued server command: /rtp
[16:08:50 INFO]: Delay: 1.5 seconds
""
Each time I ran the command, the server froze for that long, creating massive lag spikes.
Why does this happen? Well, because this line:
`set {_loc} to highest block at location ({_x}, 0, {_z})`
When this line executes, a chunk as to generate, to be able to get the highest block at that location, and while the chunk is generating the rest of the server has to wait, therefor halting the server.

On top of the extremely poor optimization this script claims to have, there's also no safety checks in where the player spawns.
The player can spawn in lava pools, in the middle of the ocean, on top of trees, you name it, because there is absolutely no check.

This script would have been fine if the dev didn't claim it was optimized, when it is the exact opposite.

This command also only supports the main world of the server.
If Im in the nether and run this, im forced back to the main world.