The menu can be improved, placeholders can be added for the status of the commands and models, the original armor is deleted when you exit and enter the game while the disco is on, this should be fixed.
Thank you for the detailed review. I will look into the issue soon and update the plugin.
Version: 6.2.2
It is an excellent plugin. But I would like the configuration to be improved a little more. For example, if we don't want to use all models, it should have a shutdown feature, a configurable GUI.
Also, we should be able to see the model on/off status in the GUI.
I'm glad you like the plugin. Disco Armor should work on Spigot 1.16.5 as long as you are using Java 17. However, I do not test with that version, so I can't provide support.
Version: 6.0.0
Please, fix Paper 1.17. All language files are present!
[13:53:41 INFO]: _TernCraft_ issued server command: /rainbow
[13:53:41 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'rainbow' in plugin DiscoArmor v6.0.0
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.17.1.jar:git-Paper-97]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.17.1.jar:git-Paper-97]
at org.bukkit.craftbukkit.v1_17_R1.CraftServer.dispatchCommand(CraftServer.java:821) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCommand(ServerGamePacketListenerImpl.java:2170) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:1981) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleChat(ServerGamePacketListenerImpl.java:1962) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundChatPacket.handle(ServerboundChatPacket.java:46) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundChatPacket.handle(ServerboundChatPacket.java:6) ~[?:?]
at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:36) ~[?:?]
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?]
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[?:?]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1348) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.server.MinecraftServer.shouldRun(MinecraftServer.java:190) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[?:?]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1327) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1320) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[?:?]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1281) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1192) ~[patched_1.17.1.jar:git-Paper-97]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:316) ~[patched_1.17.1.jar:git-Paper-97]
at java.lang.Thread.run(Thread.java:831) [?:?]
Caused by: java.lang.IllegalStateException: Missing default locale translation file!
at com.github.sirblobman.api.language.LanguageManager.getLanguage(LanguageManager.java:198) ~[?:?]
at com.github.sirblobman.api.language.LanguageManager.getMessage(LanguageManager.java:158) ~[?:?]
at com.github.sirblobman.api.language.LanguageManager.sendMessage(LanguageManager.java:181) ~[?:?]
at com.github.sirblobman.disco.armor.command.CommandDiscoArmor.showCommandUsage(CommandDiscoArmor.java:71) ~[?:?]
at com.github.sirblobman.disco.armor.command.CommandDiscoArmor.execute(CommandDiscoArmor.java:53) ~[?:?]
at com.github.sirblobman.api.command.PlayerCommand.execute(PlayerCommand.java:29) ~[?:?]
at com.github.sirblobman.api.command.Command.onCommand(Command.java:88) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.17.1.jar:git-Paper-97]
... 21 more
I'll look into it, thanks for the review. In the future please post errors on the 'Discussion' tab as I can only reply once to a review.
Version: 5.0.2
Could not load 'plugins\DiscoArmor.jar' in folder 'plugins'
org.bukkit.plugin.InvalidPluginException: Cannot find main class `com.SirBlobman.disco.armor.DiscoArmorPlugin'
at org.bukkit.plugin.java.PluginClassLoader.<init>(PluginClassLoader.java:81) ~[patched_1.16.5.jar:git-Paper-670]
at org.bukkit.plugin.java.JavaPluginLoader.loadPlugin(JavaPluginLoader.java:137) ~[patched_1.16.5.jar:git-Paper-670]
at org.bukkit.plugin.SimplePluginManager.loadPlugin(SimplePluginManager.java:397) ~[patched_1.16.5.jar:git-Paper-670]
at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:305) ~[patched_1.16.5.jar:git-Paper-670]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.loadPlugins(CraftServer.java:389) ~[patched_1.16.5.jar:git-Paper-670]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:252) ~[patched_1.16.5.jar:git-Paper-670]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1066) ~[patched_1.16.5.jar:git-Paper-670]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:290) ~[patched_1.16.5.jar:git-Paper-670]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]
Caused by: java.lang.ClassNotFoundException: com.SirBlobman.disco.armor.DiscoArmorPlugin
at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_281]
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:182) ~[patched_1.16.5.jar:git-Paper-670]
at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:111) ~[patched_1.16.5.jar:git-Paper-670]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_281]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_281]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_281]
at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_281]
at org.bukkit.plugin.java.PluginClassLoader.<init>(PluginClassLoader.java:79) ~[patched_1.16.5.jar:git-Paper-670]
... 8 more
Thanks for the review, what version did you download?
Version: 5.0.1
Latest Version of PaperSpigot 1.16.5. Please, fix! Great plugin!
[Disco Armor] Enabling DiscoArmor v5.0.1
[15:32:37] [Server thread/ERROR]: Error occurred while enabling DiscoArmor v5.0.1 (Is it up to date?)
java.lang.IllegalStateException: Not scheduled yet
at org.bukkit.scheduler.BukkitRunnable.checkScheduled(BukkitRunnable.java:156) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.scheduler.BukkitRunnable.getTaskId(BukkitRunnable.java:150) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.scheduler.BukkitRunnable.cancel(BukkitRunnable.java:30) ~[patched_1.16.5.jar:git-Paper-658]
at com.github.sirblobman.disco.armor.DiscoArmorPlugin.registerTasks(DiscoArmorPlugin.java:132) ~[?:?]
at com.github.sirblobman.disco.armor.DiscoArmorPlugin.onEnable(DiscoArmorPlugin.java:58) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:380) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:501) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:415) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:591) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:281) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1065) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:289) ~[patched_1.16.5.jar:git-Paper-658]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]
[15:32:37] [Server thread/INFO]: [Disco Armor] Disabling DiscoArmor v5.0.1
[15:32:37] [Server thread/ERROR]: Error occurred while disabling DiscoArmor v5.0.1 (Is it up to date?)
java.lang.IllegalStateException: Not scheduled yet
at org.bukkit.scheduler.BukkitRunnable.checkScheduled(BukkitRunnable.java:156) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.scheduler.BukkitRunnable.getTaskId(BukkitRunnable.java:150) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.scheduler.BukkitRunnable.cancel(BukkitRunnable.java:30) ~[patched_1.16.5.jar:git-Paper-658]
at com.github.sirblobman.disco.armor.DiscoArmorPlugin.onDisable(DiscoArmorPlugin.java:76) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:265) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.plugin.java.JavaPluginLoader.disablePlugin(JavaPluginLoader.java:415) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:516) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:384) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:501) ~[patched_1.16.5.jar:git-Paper-658]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:415) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:591) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:281) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1065) ~[patched_1.16.5.jar:git-Paper-658]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:289) ~[patched_1.16.5.jar:git-Paper-658]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_281]
Thanks for the review. I'm not sure what you mean by that option as there are many different color modes to choose in this plugin (some smoother than others)
Version: 3.0.2
Fantastic Plugin!
Requested help after the commands would not work for people who had the listed permission. Turns out it was a mess up, he fixed it, told me the correct permissions, boom it worked. He also taught me a couple of things about file editing, and turned the dull one line message into something beautiful! He also took in my suggestion about changing the look of the usage command/message... And he did it quick! Thank you so much @SirBlobMan!!!